abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
758 stars 133 forks source link

3.5: aborts on checkout with "detected dubious ownership" #93

Closed Reneator closed 2 years ago

Reneator commented 2 years ago

Using github actions i set up a workflow file that uses godot-ci. When using the previous version 3.4.4 it works no problem (retested after this error) but with 3.5 it aborts:

image

At the same location in the output for a build using godot and godot-ci 3.4.4:

image

Here the workflow file im using for 3.5:

name: "Deploy Dev-Playtest Branch"
on:
  push:
    # Pattern matched against refs/tags
    tags:        
      - '*.dev*'

env:
  GODOT_VERSION: 3.5
  EXPORT_NAME: progress_game

jobs:
  export-windows:
    name: Windows Export
    runs-on: ubuntu-latest
    container:
      image: barichello/godot-ci:3.5
    steps:
      - name: Checkout
        uses: actions/checkout@v3.0.0
        with:
          lfs: true
      - name: Setup
        run: |
          mkdir -v -p ~/.local/share/godot/templates
          mv /root/.local/share/godot/templates/${GODOT_VERSION}.stable ~/.local/share/godot/templates/${GODOT_VERSION}.stable
      - name: Windows Build
        run: |
          mkdir -v -p build/windows
          godot -v --export "Windows Desktop" build/windows/${EXPORT_NAME}.exe
      - name: Upload Artifact
        uses: actions/upload-artifact@v3.0.0
        with:
          name: windows
          path: build/windows
 [...]

The file has some more extra steps, but it already aborts with the export-windows step.

When changing the version in the workflow file im changing both the godot_version and the godot-ci version

Reneator commented 2 years ago

The same is happening for 3.4.5: image

Reneator commented 2 years ago

Bumping the version of git checkout (actions/checkout) from 3.0.0 -> 3.0.2 fixed it for me to properly build on 3.4.5 and 3.5.

image

Maybe this can be helpful to someone else googling this problem^^

But i find it quite interesting that checkout 3.0.0 works fine with 3.4.4 but doesnt work 3.4.5 onwards, checked out the changes in the godot-ci repo since 3.4.4 and it doesnt look like any huge changes that could make it break. Or maybe 3.4.5+ use a newer stable linux distribution that doesnt work with the 3.0.0 checkout action? (because a new stable linux distribution got available)