abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
758 stars 133 forks source link

3.5.1 Code-Signing Error on Mac Build? #95

Open QuintillusCFC opened 2 years ago

QuintillusCFC commented 2 years ago

Hey all, this is a great CI image, our indie game team has been using it for many months now for our builds.

I recently switched the version to 3.5.1, and noticed that the Mac build fails, with this message:

ERROR: Code Signing: Ad-hoc signed applications require the 'Disable Library Validation' entitlement to load dynamic libraries.

The actual build we used is at https://github.com/C7-Game/Prototype/actions/runs/3171446928/jobs/5165435494 . It works as expected on 3.5 and 3.4.4 without any other changes.

It could be an upstream flag that was overlooked for 3.5.1 as well; I'm not well versed enough in Mac code signing to identify the root cause.

We'll probably jump from 3.5 to 3.5.2 since we aren't great about updating every release anyway, thought I should note it though in case others are running into the same issue.

QuintillusCFC commented 2 years ago

FYI, upon further investigation this affects 3.5 (base, without the 3.5.1) on Mac too. We've kept our Mac build on 3.4.x for the time being.

Calinou commented 2 years ago

cc @bruvzg

bruvzg commented 2 years ago

The error is correct, Mono and GDNative/GDExtension require this option to be enabled if you are using ad-hoc signature (in the export options, check CodesignEntitlementsDisable Library Validation).

See https://docs.godotengine.org/en/latest/tutorials/export/running_on_macos.html, for more info about signing options.