search

abarisain / dmix

A modern MPD Client for Android.
Apache License 2.0
590 stars 205 forks source link

Issue with RTL languages #173

Closed ranperry closed 11 years ago

ranperry commented 11 years ago

I have some songs in Hebrew (A right to left language). MPDroid does not show the Hebrew text. Thanks!

Android 4.2.1 (Galaxy Nexus)

abarisain commented 11 years ago

Nothing is displayed at all ? I don't remember if Android 4.2.1 comes with Hebrew fonts (I know that <2.3 didn't) Can you please screenshot it ?

ranperry commented 11 years ago

Hebrew fonts were available since 2.2

This issue is related to Android 4.2 as both my Galaxy Nexus and Nexus 7 Tablet can not show Hebrew. My Android 2.3 shows the fonts without a problem although the text is aligned to the left. Screenshot of 4.2.1 attached:

[image: Inline image 2]

Screenshot of 2.3:

[image: Inline image 3]

On Sat, Jan 26, 2013 at 4:25 PM, Arnaud Barisain Monrose < notifications@github.com> wrote:

Nothing is displayed at all ? I don't remember if Android 4.2.1 comes with Hebrew fonts (I know that <2.3 didn't) Can you please screenshot it ?

— Reply to this email directly or view it on GitHubhttps://github.com/abarisain/dmix/issues/173#issuecomment-12742575.

ranperry commented 11 years ago

Hebrew fonts were available since 2.2

This issue is related to Android 4.2 as both my Galaxy Nexus and Nexus 7 Tablet can not shoe Hebrew. My Android 2.3 shows the fonts without a problem although the text is aligned to the left. Screenshot of 4.2.1 attached:

Screenshot_2013-01-26-16-52-18

Screenshot of 2.3:

IMG_20130126_165805

abarisain commented 11 years ago

Well, that's weird ! Do other apps display hebrew on 4.2 (I think it's a mpdroid issue anyway) ? I also think I might know why it works on 2.3 and not on 4.2

Sadly, I can't really do RTL alignement, since android doesn't allow me to do this automatically (they really suck at RTL languages support)

ranperry commented 11 years ago

Update: The Hebrew fonts are missing from the list of albums but when I do click on one of the hidden albums, I can see the text properly. See the following photo:

Screenshot_2013-02-02-09-47-30

So I guess this only happens under the list of albums and not inside the directory.

ranperry commented 11 years ago

Any update on this? Thanks!

abarisain commented 11 years ago

Sorry, didn't have the time to work on it yet, but I will sure do !

abarisain commented 11 years ago

I don't really know ... I did a lot of work, but it works okay on my phone running Android 4.2.2

Maybe I fixed something accidentally

EDIT : Nevermind, there are some problems, but they are even worse. It's not only about RTL ...

EDIT 2 : Okay ! So it was a weird combination of bugs (and a android one too). It should work great in the next version.

ranperry commented 11 years ago

Android 4.2.2 both Nexus 7 and Galaxy Nexus with MPDroid version 1.04.1

Problem is not resolved. Do you have the update in the Play Store?

Thanks!

abarisain commented 11 years ago

Do you have the update in the Play Store?

No, it's only in my current branch. It will be solved in the next Play Store update, but I don't know when I'll release it.

ranperry commented 11 years ago

Many thanks!

burmar commented 11 years ago

Hello Arnoud I can't find anymore beta versions downloads... where are they gone?

abarisain commented 11 years ago

Yeah, github removed them ... I'll compile one and link you to the apk

burmar commented 11 years ago

Thanks :)

ranperry commented 11 years ago

Please let me know as well.

abarisain commented 11 years ago

I'll let you once I get something that works. I'm currently in the process of redoing a big part of the interface, and as a result the Now Playing queue is totally broken (it lacks any reordering feature).

Not sure you want this kind of build

abarisain commented 11 years ago

Ok, I disabled the broken code. here you go : http://ompldr.org/vaGtmOA/MPDroid-Snapshot-23-02-2013.apk You may need to uninstall mpdroid before reinstalling this, but if you decide to keep this version, the next market version will install over it without any problem. The play store will detect the updates and stuff.

Please note that mpdroid is in the middle of a HUGE rework of how the views work, so there might be some problems.

Tell me if you have RTL problems (or any other feedback) !

burmar commented 11 years ago

Thanks Arnoud... i'll try in next days If there are issues i will uninstall it and reinstall from market...

abarisain commented 11 years ago

Psst my name is Arnaud, not Arnoud ;)

ranperry commented 11 years ago

Have been playing with the new version for the last couple of hours.

  1. RTL Language issue is resolved!
  2. The scroll issue is resolved. Now you can click on the mini scroll bar on the side and zip through your folder.
  3. The new layout with the mini "now playing" plus the small art work is great.
  4. The ability to navigate into the album / artist / folder is great.
  5. Play Queue is still buggy. Some issues with files number missing or file name missing (see screenshot)

Overall, very impressive release. MPDroid is the only application that I know that fully capture the potential and flexibility of MPD.

Well done!

This is how the folder list looks like (this is good):

proper_file_listing

This is how the play queue list looks like (this is bad...)

buggy_play_queue

I will keep playing with it throughout the weekend....

abarisain commented 11 years ago

Oh right ! I forgot to propagate the changes to the play queue.

It's being redone anyway :) But thanks

burmar commented 11 years ago

:(((( i'm sorry for name's mistakes!!! Arnaud... Now i'll write in my brain like in a stone!!! ;)) Thanks for all..