search

abarisain / dmix

A modern MPD Client for Android.
Apache License 2.0
589 stars 205 forks source link

Problem with MPDroid-beta and multi-album-artists #504

Closed MPconta closed 9 years ago

MPconta commented 10 years ago

Albums with more than one "Artist" behave very well in MPDroid - they appear under the different artists as they should. But when i use more than one "Album-Artist" the behaviour gets strange when the specific tag for the artists-listing in the menu is chosen: The album with the (for example) 2 album-artists is showed for both of the artists as ist should, but not once but twice. One time for each artist, but under the wrong artist. An example: I have an album with Eric Clapton and B.B. King as 2 "Album Artist". When i now choose Eric Clapton in the library, there are 2 similar albums. When i change the specific tag for the artists-listing in the menu from "Album Artist" to "Artist", the behaviour is the same (I have the same value for "artist" and "album artist"). But when i eliminate the "album artist"-tag in the tracks, the behaviour is normal again.

hurzl commented 10 years ago

There is no such thing as an album with 2 album-artists. That means 2 albums.

MPconta commented 10 years ago

No, its the same like the "artist"-tag. You can have 2 (or more?) of them. In the tag field you simply write both names devided with two backslashes. For "artist" it works perfectly, but for "album-artist" it makes problems. Meaning it gives you doubled results.

Background: With MPDroid its hard to handle compilations (compiled albums like "best of the 70s" or something). For this functionality i fear, i have to copy the "artist" to the "album-artist"-tag and change the specific setting in MPDroid. And there are a lot of albums with more than 1 artist.

abarisain commented 10 years ago

Compilations work for me. A compilation's album artist tag will be the one who released the CD.

I've got these compilations called "Nova Tunes". The album artist tag is "Radio Nova", and the artist tag is for example " Bob Dylan " or "Daft Punk". They get grouped correctly here.

MPconta commented 10 years ago

Yes, but then you find the album only under "Nova Tunes". But when you take the album "Ride with the king" from Eric Clapton and B.B.King, you want to find it under Eric Clapton AND B.B. King.

abarisain commented 10 years ago

I think I find it under the individual artists if I use "Both". but then the artist list is super long ... can't have everything.

Don't have my server up and running, so can't test.

hurzl commented 10 years ago

Since when does mpd split tags by "\"?

MPconta commented 10 years ago

I don't know since when - i am using MPDroid only for 3 months. But it works out perfectly. You only put 2 "\" without space between the names and the album ist listed under both artists.

The only problem now (for me) is: to handle the compilations in my music-collection, it seems i have to search by "album-artist" instead of "artist". But for the "album-artist" the splitting does not work that good. You see the album under both artists, but doubled - one for each artist. So you have a wrong artist in your artist-range.

Hope you understand me - its difficult to describe. :-) But it seems to be just a small bug, as far as MPDroid is searching for "album-artist" in the very same way as for "artist".

MPconta commented 10 years ago

Just for curiosity: Does the splitting come from MPD or does MPDroid handle the tags and creates the library out of that information?

abarisain commented 10 years ago

I do not manage the library myself. Except for the album cache, MPD handles it.

hurzl commented 10 years ago

But for the "album-artist" the splitting does not work that good. You see the album under both artists,

That's ok I guess

but doubled - one for each artist.

Album is listed twice in albums list?

So you have a wrong artist in your artist-range.

Don't understand this

Btw. is the "\" feature of mpd documented somewhere?

MPconta commented 10 years ago

"Btw. is the "\" feature of mpd documented somewhere?"

As far as i know, its a regular feature for a lot of media-players. At least in Mp3tag (proggi for tagging tracks) it is well known and used.

To clearify the misbehaviour: Imagine you have the album of Eric Clapton and B.B. King "Ride with the king". You have the "artist"-field tagged with "Clapton(2x backslash)King". Then you copy this content to the "album-artist"-field. In MPDroid you have chosen the option "search for album-artist" in the settings.

Well, now you open MPDroid and go to the genre "Blues". There you choose the artist "Eric Clapton". And then you see the album "Ride with the king" two times. To be exact: you see two identical covers of the album, one labeled with "Eric Clapton" and the other one labeled with "B.B.King". I would say, the second one is wrong here!

Hope you understand now - sorry for the long explanation. It's kind of hard to explain. :-)

hurzl commented 10 years ago

Do you get this error with and without album cache?

MPconta commented 10 years ago

Without album cache. I got some problems with album-cache and avoid this option.

hurzl commented 10 years ago

Without cache the double album must come from mpd I think. You could check with a command line client

list album albumartist  "Eric Clapton"
MPconta commented 10 years ago

Yes, when Arnaud says he does not manage the library, the problem has to come from MPD. Well, then i will open a ticket there - hope the devs are not too rude to me...

For the check: Do you mean a command-line-client for android? Did not know that something like that exists.

abarisain commented 10 years ago

Use telnet. MPD is a plaintext api

MPconta commented 10 years ago

Hmmm, sorry - no expert here... :-) telnet?!

abarisain commented 10 years ago

Use the telnet program from your platform, connect it to mpd (just give it mpd's ip and port) and you will be able to input commands.

If you have a password, don't forget to send "password " before what hurzl told you to run.

hurzl commented 10 years ago 
$ telnet <host> 6600

or check clapton with other mpd clients

hurzl commented 10 years ago

I just tried tagging "Liszt\Beethoven" and I don't get the 2 artists. I get the literal string as artist

What tagger do you use?

MPconta commented 10 years ago

Thanks for the info!! I will give my best to try it in the evening, when i am home again.

MPconta commented 10 years ago

@hurzl : Thats VERY strange. With which program did you try? I take Mp3tag - maybe the program changes the entry? EDIT: Are you sure, you put only the 2 backslashes without spaces between the names?

hurzl commented 10 years ago

I take Mp3tag - maybe the program changes the entry?

Probably, I use easytag

hurzl commented 10 years ago

Hmm there is no such thing as mpd 0.19 http://www.musicpd.org/download.html

abarisain commented 10 years ago

Isn't 0.19 the name of the current git version ?

MPconta commented 10 years ago

0.19 is the git-version. But the last stable should be very similar.

kingosticks commented 10 years ago

"//" as a separator is an Mp3tag specific "feature" but hopefully what is actually written to the file header depends on what tag version you've selected for output. e.g. with id3v2.4 it should replace all "//" strings with a null character; while id3v2.3 should replace with a "/" character. Other tagging programs probably have different ways to represent the separation character, or they may not support multiple field values at all. The good thing about using null characters is that programs that don't understand it will only see the first value, which is hopefully the "main" artist and so not a complete disaster if you only get this.

hurzl commented 10 years ago

For the flac or mp3 it shouldn't matter what the tagger uses for separation. It should just contain multiple tags. I'm only surprised that mpd handles them

kingosticks commented 10 years ago

Mp3 allows multiple tags of the same type? Are you sure? Flac does certainly. But mp3 I'm pretty sure doesn't. On 24 Mar 2014 19:43, "hurzl" notifications@github.com wrote:

For the flac or mp3 it shouldn't matter what the tagger uses for separation. It should just contains multiple tags. I'm only surprised that mpd handles that.

Reply to this email directly or view it on GitHubhttps://github.com/abarisain/dmix/issues/504#issuecomment-38491251 .

hurzl commented 10 years ago

No, I don't know anything about mp3

MPconta commented 10 years ago

Well, in my case the situation is following: It's flac-files and i opend >(the smallest...) one with a text editor. The content does not tell me which kind of tags there are, but the tags are in the very beginning of the file, at the end there are none. And the informations for "artist" and "album-artist" are seperatet. It looks like: ... artist=Eric Clapton artist=B.B.King genre=blues albumartist=Eric Clapton albumartist=B.B.King ... And yes, not every mediaplayer shows me both artists. For example vlc shows me only one of them. Foobar2000 schows both as it should be.

MPconta commented 10 years ago

Ok, and i tested this telnet-thing --> it works out! :-) For: list album artist "Eric Clapton" and list album albumartist "Eric Clapton" i get the same results, including the album with 2 artists. Same for B.B. King.

The strange thing: the other 5 albums of Clapton does not have an albumartist, but they are also in the result-list of: list album albumartist "Eric Clapton" --> Strange!

EDIT: Very interesting: It seems, that MPD gives out the albumartist if there is one. If there is none, it gives for the "albumartist" the same content as the one saved in "artist". So you get always a result for "albumartist", even if there is none. That would be very intelligent to my opinion. But then the mistake points to MPDroid again?!

hurzl commented 10 years ago

That's the AA-fallback of mpd

Do you get 1 or 2 albums listed?

MPconta commented 10 years ago

"Do you get 1 or 2 albums listed?"

What exactly do you mean with that?

hurzl commented 10 years ago

You complained about getting your album twice in MPDroid

abarisain commented 10 years ago

Well if mpd reports albums with the same name for two dinstinct artists mpdroid will see them in double.

MPconta commented 10 years ago

Ah, i understand. No, i get the album "Riding with the King" only once for Eric Clapton. And also once for B.B.King.

MPconta commented 10 years ago

@abarisain : But why does it work out when i search for "artist"?

abarisain commented 10 years ago

I don't know . i really don't see what we're doing wrong from our side

MPconta commented 10 years ago

Ok, i just see, that there is the same problem with the doubled albums also when i search for "artist", but the "albumartist"-tag is still set.

It is clear now, that it is not needed to copy the value from "artist" to "albumartist", because MPD makes that from itselfe. Maybe that causes the confusion?

But when i kill the "albumartist"-tag, i don't see the artists anymore when i search in genres. I see there only the albums with explicit written "albumart"-tag. (When searching with option "Albumartist"!)

hurzl commented 10 years ago

Try if you have that problem with cache

MPconta commented 10 years ago

Ok, tested it with album-cache. Before i deleted the "album-artist"-tag in the Clapton/King-album because it seems, that they are counterproductive. And the option is set to "search for artist". Then i switch album-cache on. --> The albums with only 1 artist are shown as usual, the albums with 2 artists are shown for only one artist. In my case the album is shown when i choose B.B. King, but is not shown when searching under Clapton. Well, then i changed the search-option from "artist" to "album-artist". --> When looking in Genres, no artists are shown. Only the mixed-albums with a specific name in the "albumartist"-tag are found. All the rest not. So it did not work out very well, but at least it was not necessary to re-install MPDroid - it's necessary to shut down the program and restart it.

abarisain commented 10 years ago

I'll make it obvious that most options reqyire a mpdroid restart.

Or restart it automatically.

MPconta commented 10 years ago

When MPDroid goes to the background it looks very similar to shutting it off. Now i know there is a difference... :-)

kingosticks commented 10 years ago

For the record, that's not unique to Mpdroid. That's Android. On 25 Mar 2014 09:21, "MPconta" notifications@github.com wrote:

When MPDroid goes to the background it looks very similar to shutting it off. Now i know there is a difference... :-)

Reply to this email directly or view it on GitHubhttps://github.com/abarisain/dmix/issues/504#issuecomment-38544073 .

abarisain commented 10 years ago

MPDroid does something a little bad though : The back key is overriden on the main menu to kill the app and not only the activity. That's not something that should be done, but with our long history of battery drainage ... It's required. I'll get rid of it as soon as I can

MPconta commented 10 years ago

Ok, but thats not the problem here i would say. When MPDroid is used in a normal way, its not necessary to shut it down - it works great when only put to background sometimes!

More problematic for me is the strange behaviour of the library. When i use the direct command:

i get 6 different results for the albums where Clapton is artist (3 albums as solo-artist, 3 albums as artist together with another, i.e. B.B.King). But when i search in MPDroid for "albumartist" i don't find anything in the appropriate genre. --> Thats strange!

When i come home, i will check, if MPDroid find the albums when i search not under Genres, but direct under Artist.

MPconta commented 10 years ago

Well, it's getting clearer (or not...): When i have search-option "albumartist" activated and search in Genres, i don't find anything. But when i search under Artists, i find all of the albums. So it seems to be an assignment-bug?!

BUT: It seems, that MPDroid does not really look for "albumartist" but for "artist" - the results are very much the same. Is that caused by the fact, that you search with option "albumartist" under Artist? I have to confess - i am a little confused...

MPconta commented 10 years ago

Mybe a way tho get clearification: I got an mixed-album "60s hits" with one song "Diana" from "Paul Anka". So artist is "Paul Anka" albumartist is "60s hits" and album is again "60s hits" ok? So what should bring:

  1. list album albumartist "Paul Anka"
  2. list album albumartist "60s hits"
  3. list album artist "Paul Anka"
  4. list album artist "60s hits" ? I will test in the evening.
MPconta commented 10 years ago

Well,

  1. list album albumartist "Paul Anka" --> no result
  2. list album albumartist "60s hits" --> "60s hits"
  3. list album artist "Paul Anka" --> "60s hits"
  4. list album artist "60s hits" --> no result

As far as i understand, this is a reasonable result. What do you say?