search

abarisain / dmix

A modern MPD Client for Android.
Apache License 2.0
591 stars 198 forks source link

File mode doesn't display last flac file #519

Closed adelias closed 10 years ago

adelias commented 10 years ago

While in file mode the last flac file in the directory is not being displayed.

avuton commented 10 years ago

I am a heavy Library File user, and I just checked quite a few directories and could not duplicate this. Could you check with another client or manually through telnet to make sure it's coming through your server?

adelias commented 10 years ago

I had tested this with all the other clients that I have before posting. These clients include gmpc, ncpmc, ncpmcpp as well as through telnet. One thing that I forgot to mention is that if I add the entire directory to the playlist, the last file does appear in the playlist.

abarisain commented 10 years ago

I wonder if it's related to the parser changes I made for directory improvement. The last built item isn't maybe completed.

If you can, can you give us the telnet output for the folder list where the bug appears ? (and tell us which item doesn't show up) Thanks in advance.

On Tue, Apr 15, 2014 at 11:11 PM, adelias notifications@github.com wrote:

I had tested this with all the other clients that I have before posting. These clients include gmpc, ncpmc, ncpmcpp as well as through telnet. One thing that I forgot to mention is that if I add the entire directory to the playlist, the last file does appear in the playlist.

— Reply to this email directly or view it on GitHubhttps://github.com/abarisain/dmix/issues/519#issuecomment-40534954 .

avuton commented 10 years ago

Related to #435?

adelias commented 10 years ago

I'm running mpd 0.18.9 (no mopidy or musicbox). Here is an example directory where the file "04 - Part 4 - Psalm.flac" doesn't show up: 52956 01\ -\ Part\ 1\ -\ Acknowledgement.flac 51122 02\ -\ Part\ 2\ -\ Resolution.flac 69824 03\ -\ Part\ 3\ -\ Pursuance.flac 44055 04\ -\ Part\ 4\ -\ Psalm.flac 4 A\ Love\ Supreme\ [Deluxe\ Edition].CUE 4 A\ Love\ Supreme\ [Deluxe\ Edition].log 4 John\ Coltrane\ -\ A\ Love\ Supreme\ [Deluxe\ Edition].m3u 52 folder.jpg

This is happening with all my flac files, mp3 files are showing up fine in file mode.

Thanks

abarisain commented 10 years ago

I wonder if this is triggered when the next element if of another type (here CUE).

adelias commented 10 years ago

Removing both CUE and M3U files from the directory fixes the issue. Removing only one of the two does not.

abarisain commented 10 years ago

Thanks, i'll look into the parser.

abarisain commented 10 years ago

As said in the commit, I have rewritten the hackish parser responsible of this bug.

Fix will be available in next beta release.