search

abarisain / dmix

A modern MPD Client for Android.
Apache License 2.0
587 stars 205 forks source link

Lyrics support #574

Closed AlexParamonov closed 10 years ago

AlexParamonov commented 10 years ago

Integration with musiXmatch player would be the best

klainkaliber commented 10 years ago

BubbleUPnP has this nice feature - if you tap on the cover in the "now playing" screen, it opens musiXmatch and this shows the lyrics.

abarisain commented 10 years ago

Hello !

Sorry, but this wont happen, or at least not with musiXmatch.
Implementing lyrics is a requested feature, and some providers even told me that they would be glad to help me :)

But, no musiXmatch ... Why, do you ask ?
https://github.com/musixmatch/android-lyrics-plugin-sdk

Their SDK (which is probably deprecated since it is from 2011) requires me to accept their terms and wait for the approval before publishing or distributing the application in any form .
That's a huge no. As a strong believer of free and open source code, such a clause is unacceptable, especially for MPDroid, which is distributed on F-Droid (and I want to stay there).

Okay, then why not any other provider ?
The following article explains why I don't want to do this : http://www.androidpolice.com/2012/11/24/apollo-cms-music-player-pull-from-the-play-store-due-to-alleged-copyright-infringement/

Since Lyrics are a gray area and would put MPDroid in the danger of being pulled from the Play Store (and I really, really don't want that) if I implemented them without using musiXmatch, I'll play it safe : I will not integrate any lyrics support. Sorry.

AlexParamonov commented 10 years ago

Ok, I understand, @abarisain. @klainkaliber thank you for pointing out to BubbleUPnP will try to use it together with MPDroid

martignlo commented 8 years ago

It looks like it is possible to integrate with musiXmatch using broadcast intents: https://developer.musixmatch.com/documentation/floating-lyrics.

This method does not seem to require to accept any term and it doesn't seem dangerous (since mpdroid won't need to access any lyric but just broadcast what's being currently played).

abarisain commented 8 years ago

Hi and thanks for your feedback.

MusiXmatch could use the remote control APIs... Anyway, I'm not really against that since they are """standard""" broadcasts. One advantage of doing that would also be helping Lastfm scrobblers recognize mpdroid.

avuton commented 8 years ago

This has already been fixed by #20, I mean, sure additional functionality, blah blah, but seriously, there is enough stuff to do without adding more support for something already support.

abarisain commented 8 years ago

It is with great shame that I'm admitting that I never saw that commit :D

avuton commented 8 years ago

Probably a lesser known feature :+1:

n03l commented 8 years ago

It would be nice if QuickLyric used the same exact approach (the intent seems to be a standard one) so that a single method would work with multiple lyrics apps.

Anyway, I understand, that this is definitely a very low priority request. I just wanted to point out that there exist a very simple way to integrate with MusiXmatch.