search

abarisain / dmix

A modern MPD Client for Android.
Apache License 2.0
590 stars 205 forks source link

Cover art quality degraded during some loads. #623

Open MPconta opened 10 years ago

MPconta commented 10 years ago

On my Nexus 10 i have a strange issue with the cover-art of albums:

When i turn the tablet in the "now-playing"-mode for 90 degrees to get a real big cover, the picture often turns blurred. This happens very often, about 7 of 10 times. And it does not depend on the picture - with the same cover sometimes everything is ok and most of the time the result is blurred.

Also sometimes the cover-art disappears when turning the tablet, but not too often.

Is there an explanation for this problem?

abarisain commented 10 years ago

Weird that it happens so often, but yeah it's a known issue. Can't remember what happens behind the scenes, I think that the CoverManager gets fed a wrong cover size (needed size is guessed at runtime) and falls back to a default value, which is too small for a Nexus 10.

MPconta commented 10 years ago

Yes, thats a good explanation. Do you think there is a solution to this?

PS: and it's funny, that the guessing sometimes brings good results. :-)

avuton commented 10 years ago

Yeah, I see it often too. It's one of those things. I'd love to fix it, but my priorities lie elsewhere.

abarisain commented 10 years ago

There is a solution, but no easy fix. Also hard to test because it does not happen that often for me.

MPconta commented 10 years ago

I can do the testing, if you want. On my side it's very easy to see, if it works out or not. :-)

MPconta commented 9 years ago

It seems, with the new version of MPDroid nothing has changed to the discribed behaviour. When it helps - it is said, that 300dpi is a good value for the presentation of pictures. If you set the guessed size, which is needed to set in runtime, to this value, maybe it work out for most of all posssibilities?

abarisain commented 9 years ago

I confirm that nothing changed.

"300dpi" means nothing to me. I have to know the wanted pixel size to decode the image so that I don't waste ram. I can't unpack 2560×1600 cover arts for EVERY line of a list, these stupid screen resolutions force us to make a lot of optimisations so we can show a crisp cover art with 10 mb of heap

MPconta commented 9 years ago

It really has to be the same size for the thumbnail in the Album-List and for the picture in the actual-album-view? Then i fully understand the problem!

abarisain commented 9 years ago

No it doesn't have, but we have to know which size the view we'll display in is. Sometimes, android will tell us "0", so we fall back on a default value. That needs to be improved.

2015-01-15 11:48 GMT+01:00 MPconta notifications@github.com:

It really has to be the same size for the thumbnail in the Album-List and for the picture in the actual-album-view? Then i fully understand the problem!

— Reply to this email directly or view it on GitHub https://github.com/abarisain/dmix/issues/623#issuecomment-70068711.