search

abarisain / dmix

A modern MPD Client for Android.
Apache License 2.0
590 stars 198 forks source link

New develop branch problems #706

Open hurzl opened 9 years ago

hurzl commented 9 years ago
abarisain commented 9 years ago

Gap between list items in QueueFragment

I lessened it. https://github.com/abarisain/dmix/commit/359e8f997646baf7bf75c01aa87983b522a1d922

Album view cover clutters/is cluttered by top menu

That will probably won't change or get worse since I'll apply a shadow. I need to find a solution for showing cover art perfectly for you cover art lovers (which makes redesigning now playing really f*\ hard)

All the lists (albums, artists etc.) jump to the beginning when coming back to them

I don't have that problem, but yeah, that's not intended

hurzl commented 9 years ago

Gap between list items in QueueFragment

I lessened it. 359e8f9

Why is there a gap in QueueFragment, but not in AlbumsFragment?

Album view cover clutters/is cluttered by top menu

I need to find a solution

Not possible to just move the cover below the menu bar?

All the lists (albums, artists etc.) jump to the beginning when coming back to them

I don't have that problem, but yeah, that's not intended

strange

abarisain commented 9 years ago

Why is there a gap in QueueFragment, but not in AlbumsFragment?

Because I show more info ? And really, everything isn't done yet. There will be more padding that there was today in QueueFragment.

Not possible to just move the cover below the menu bar?

Looks way uglier to me, and pushes the UI way below. I would have liked for it to go even under the statusbar. I don't mind showing some mockup experiments. Cover art is more of a filler to me, rather than your point of view, which is something you want shown with no alteration. Once again, now playing will be hard :/

hurzl commented 9 years ago
abarisain commented 9 years ago

We have nothing of value to show in the drawer so its gone. It may come back if we have a use for it. The section titles ? Which ones ? I don't get how now playing is worse now though. It's still a tap away.

_____________________________

From: hurzl notifications@github.com Sent: vendredi, mai 8, 2015 11:15 AM Subject: Re: [dmix] New develop branch problems (#706) To: abarisain/dmix dmix@noreply.github.com Cc: Arnaud Barisain-Monrose abarisain@gmail.com

    The old layout was better. Why is the Navigation Drawer gone, I thought this was now android standard? It was a good place to show a server list. Also the section titles of "Albums", "Artists" etc. are unnecessary, they only use up space. And it is uncomfortable to get to and out of NowPlaying.

— Reply to this email directly or view it on GitHub.

hurzl commented 9 years ago

The section titles ? Which ones ?

The library tabs?

I don't get how now playing is worse now though. It's still a tap away.

Right, I remembered it incorrectly. You get out by the back key. But it is/was easier to drag it down ...

abarisain commented 9 years ago

The library tabs are not really onnecessary ... How do you know which tab you're in

On Fri, May 8, 2015 at 6:43 AM -0700, "hurzl" notifications@github.com wrote:

The section titles ? Which ones ?

The library tabs?

I don't get how now playing is worse now though. It's still a tap away.

Right, I remembered it incorrectly. You get out by the back key

— Reply to this email directly or view it on GitHub.

hurzl commented 9 years ago

The library tabs are not really onnecessary ... How do you know which tab you're in

Ok so I could say "the title bar is unnecessary"?

abarisain commented 9 years ago

Both could be collapsed , at least at scroll yeah

On Fri, May 8, 2015 at 6:51 AM -0700, "hurzl" notifications@github.com wrote:

The library tabs are not really onnecessary ... How do you know which tab you're in

Ok so I could say "the title bar is unnecessary"?

— Reply to this email directly or view it on GitHub.