Various improvements related to dismissing items

abarth / app-widgets

Experiments in creating Polymer elements for mobile web apps

33 stars 11 forks source link

Various improvements related to dismissing items #1

Closed kenchris closed 10 years ago

kenchris commented 10 years ago

Multiple patches improving the the dismissing of items:

actually modify the data store
fix the animations in most cases (with the exception of the animateHeightOnDismiss)
implement the Android GMail behavior.

Feedback welcome. I can easily merge and split patches if needed.

kenchris commented 10 years ago

OK @ojanvafai I fixed the last comment and rebased the patch now that Erik made some changes.

kenchris commented 10 years ago

@ojanvafai fixed now.

kenchris commented 10 years ago

Rebased and removed some commits which are no longer needed

arv commented 10 years ago

This is really nice. Mostly nits at this point.

kenchris commented 10 years ago

@arv thanks! I uploaded a new version with the fixed for the issues you pointed out.

arv commented 10 years ago

LGTM

@ojanvafai Do you usually squash things together or should we just merge and don't care about extra commits?

kenchris commented 10 years ago

OK, I fixed the off by one indentation.

If you want, I can squash them all

ojanvafai commented 10 years ago

We don't have a usually. Either way is fine with me. On Feb 19, 2014 2:31 PM, "Erik Arvidsson" notifications@github.com wrote:

LGTM

@ojanvafai https://github.com/ojanvafai Do you usually squash things together or should we just merge and don't care about extra commits?

Reply to this email directly or view it on GitHubhttps://github.com/abarth/app-widgets/pull/1#issuecomment-35558108 .