abartov / bybeconv

Project Ben-Yehuda's content management system.
https://benyehuda.org/
Other
10 stars 5 forks source link

Consider moving all configurations to ENV variables #166

Open damisul opened 2 years ago

damisul commented 2 years ago

I'm setting up configuration for Github Actions, and facing one problem again: I need to create set of configuration files to store settings for db, chewy, etc.

One possible way to simplify this process is to move settings to environment variables. In production it will be real env vars, but for development and test purpose we can use gem like dotenv-rails: https://github.com/bkeepers/dotenv

What do you think?

I can make a small PR for migrating some of settings to this approach so you can evaluate it first.

abartov commented 2 years ago

Sounds good!

A.

On Mon, Jun 20, 2022 at 7:58 AM Damir Sultanbekov @.***> wrote:

I'm setting up configuration for Github Actions, and facing one problem again: I need to create set of configuration files to store settings for db, chewy, etc.

One possible way to simplify this process is to move settings to environment variables. In production it will be real env vars, but for development and test purpose we can use gem like dotenv-rails: https://github.com/bkeepers/dotenv

What do you think?

I can make a small PR for migrating some of settings to this approach so you can evaluate it first.

— Reply to this email directly, view it on GitHub https://github.com/abartov/bybeconv/issues/166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQFJ2JSIWE7WMQWOMUKSTVP727RANCNFSM5ZHSXBIQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Asaf Bartov @.***>