abartov / bybeconv

Project Ben-Yehuda's content management system.
https://benyehuda.org/
Other
10 stars 5 forks source link

Authors search after #322

Closed damisul closed 2 months ago

damisul commented 2 months ago

This PR modifies authors browse page to use search_after for pagination and adds filtering by first letter of name.

Also in this PR I've started work on unifying pagination/filtering logic between authors and works pages. I've extracted common code into FilteringAndPaginationConcern file, to reduce code duplication. This is far from being perfect for now, but I believe it is a good first step in this direction.

NOTE: for search_after functionality I had to add id column to PeopleIndex (it is used a tie-breaker when two records has same value of sort-by field)

P.S. this PR is based on works_search_after branch and is expected to be merged into it.