abartov / bybeconv

Project Ben-Yehuda's content management system.
https://benyehuda.org/
Other
10 stars 5 forks source link

Unused title column in People table #348

Closed damisul closed 1 month ago

damisul commented 1 month ago

I see there is a 'title' column declared in People table:

t.string "title"

But in db I have all records have title as null or empty string. Person edit form also does not displays this column.

So I wonder if this field is really used? Unfortunately 'title' is widely used in codebase, so it is hard to quickly check all places.

If it is not used I propose to delete it.

abartov commented 1 month ago

It is not used and can be removed.

I think at some point I added a title method to Person, returning name, to ease polymorphism. But the DB field is not used or needed.

A.

On Wed, May 15, 2024 at 9:13 PM Damir Sultanbekov @.***> wrote:

I see there is a 'title' column declared in People table:

t.string "title"

But in db I have all records have title as null or empty string. Person edit form also does not displays this column.

So I wonder if this field is really used? Unfortunately 'title' is widely used in codebase, so it is hard to quickly check all places.

If it is not used I propose to delete it.

— Reply to this email directly, view it on GitHub https://github.com/abartov/bybeconv/issues/348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQFJ2C5WNIRBTEDQG4EI3ZCOQS5AVCNFSM6AAAAABHYVKJ3GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4TQNJSHA2DSNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Asaf Bartov @.***>