abartov / bybeconv

Project Ben-Yehuda's content management system.
https://benyehuda.org/
Other
10 stars 5 forks source link

Replace WikidataID with WikidataURI in Person table #352

Closed damisul closed 1 month ago

damisul commented 1 month ago

From telegram discussion:

@damisul

In corporate_bodies we have t.string "wikidata_uri" column, but in People we have t.integer "wikidata_id".

I wonder if they used to store same information? (probably for People we can construct wikidata_url using wikidata_id?)

If so I propose to move those columns to Authorities table. We just need to decide what should we use: numeric ID or URIs ?

@abartov

Yes, their purpose is identical. It's cleaner to store the URI as a string, I suppose, instead of relying on knowledge of the (indeed very stable) URI structure of Wikidata.

So I propose to migrate existing Wikidata_id values to Wikidata_uri in Person table before creating Authorities table