search

abashev / vfs-s3

Amazon S3 driver for Apache commons-vfs (Virtual File System) project
Apache License 2.0
93 stars 50 forks source link

Fix support of DelegatingFileSystemOptionsBuilder #50

Closed sergey-derugo closed 5 years ago

sergey-derugo commented 5 years ago

Fix support of DelegatingFileSystemOptionsBuilder (commons-vfs). Add unit tests to prevent such regression issues in the future.

Note: this fix is required to provide compatibility with the previous versions of the vfs-s3. Here is the sample code which works with the 2.X version of the vfs-s3

        FileSystemManager manager = VFS.getManager();
        FileSystemOptions options = new FileSystemOptions();
        DelegatingFileSystemOptionsBuilder builder = new DelegatingFileSystemOptionsBuilder(manager);
        builder.setConfigString(options, "s3", "region", "us-east-1");
sergey-derugo commented 5 years ago

The constant com.github.vfss3.S3FileProvider.SCHEMA="s3" has been introduced.