search

abashev / vfs-s3

Amazon S3 driver for Apache commons-vfs (Virtual File System) project
Apache License 2.0
93 stars 50 forks source link

Not all classes from aws-java-sdk-s3 are shadowed #65

Closed boris-petrov closed 4 years ago

boris-petrov commented 4 years ago

Some classes in the com.amazonaws package are not "shaded". This means that when I also import aws-java-sdk-s3 to use it in my own code, the loading of these classes is non-deterministic and runtime exceptions occur because of incompatible classes.

Either all classes from aws-java-sdk-s3 should be "shaded" or it should be used as a dependency (of course, that leads to issues like https://github.com/abashev/vfs-s3/issues/64).

P.S. I'm talking about vfs-s3 version 4.2.0.

skarzhevskyy commented 4 years ago

Ideally there can be two artefacts with aws-sdk-shaded and vfs-s3 that have project classes only

abashev commented 4 years ago

From now we have the raw artifact and with-aws-sdk classifier.