compute_and_set_fscore (and compute_score) depend on Algorithm, but they only use self.patterns and have no other interactions with Algorithm and they take a mutable reference on Node. Shouldn't they depend on Node instead ?
Literally the same issue with node_generator and get_potential_moves
Algorithm::patterns should be moved elsewhere or something
Fscore (concept) should be in Node and not Goban for obvious reasons
compute_score is just too long and could be split in many functions
compute_and_set_fscore
(andcompute_score
) depend on Algorithm, but they only useself.patterns
and have no other interactions with Algorithm and they take a mutable reference on Node. Shouldn't they depend on Node instead ?node_generator
andget_potential_moves
Algorithm::patterns
should be moved elsewhere or somethingcompute_score
is just too long and could be split in many functions