abathur / resholve

a shell resolver? :) (find and resolve shell script dependencies)
MIT License
231 stars 5 forks source link

support mkDerivation `finalAttrs` call pattern? #107

Open abathur opened 1 year ago

abathur commented 1 year ago

I won't pretend to have the firmest grasp of this, but nixpkgs reviewers are leaning heavily on PR authors to use the mkDerivation (finalAttrs: ...) pattern first added in:

After skimming related PRs, my best guess is that I'll want to wait to tackle this until the following PR implementing lib.extendMkDerivation lands:

Since resholve's mkDerivation will need work to support this and it doesn't look immediately tractable, there'll probably be an increasing number of people getting asked to implement this (as in https://github.com/NixOS/nixpkgs/pull/224881#discussion_r1325328885) only to run into a dead end for now.

D3vil0p3r commented 9 months ago

Any news about it?