search

abatilo / actions-poetry

GitHub Actions for Python projects using poetry
MIT License
427 stars 43 forks source link

feat: Add ability to install plugins as part of the action setup #66

Closed xSAVIKx closed 10 months ago

xSAVIKx commented 10 months ago

So starting somewhat time soon Poetry will not install plugins (such as export plugin e.g.) by default. So this PR add ability to install plugins by default and also installs the export plugin for you by default.

As part of the PR I have also updated versions of the GH actions used in workflows.

xSAVIKx commented 10 months ago

@abatilo can you please take a look? It'd be great to have this feature

abatilo commented 10 months ago

This seems reasonable to me!

xSAVIKx commented 10 months ago

@abatilo, right, so a particular version of plugin requires a particular version of poetry. This means that we can have this feature, but let user decide if they want to install smth by default. At least that probably is a safer default strategy.

Can you please run the CI once again?

xSAVIKx commented 10 months ago

@abatilo there's a required check configured and the Ubuntu version was updated to 22.04, so the check never passes. Can you please change the check and maybe merge the PR if everything looks OK?

xSAVIKx commented 10 months ago

@abatilo, sorry to bother but as I mentioned in the previous comment, while the Ubuntu has changed to v22.04 the required check you have right now will be never triggered and thus there's no way to proceed with merging the PR.

It would be great if you can reconfigure the check or force-merge the PR

abatilo commented 10 months ago

Sorry for the delay @xSAVIKx, I had gone on holiday. I'm happy with a force merge!

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: