search

abatten / fruitbat

A fast radio burst (FRB) redshift estimation package written in Python.
https://fruitbat.readthedocs.io
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

update dependencies #27

Closed zingale closed 5 years ago

zingale commented 5 years ago

In the README.md, please consider addingpybind11 to the list of dependencies.

zingale commented 5 years ago

also please consider adding this to the sphinx documentation in the "Getting Started" section.

abatten commented 5 years ago

In pull request #25 I originally added pybind11 to the list of requirements to avoid the Failed building wheel for pyymw16 error even though it correctly install it appears that it didn't. However this didn't seem to resolve the issue as it is an issue with the pyymw16 package. The author of the pyymw16 package appears to have a fix (telegraphic/pyymw16#1), I am waiting for the changes to be made available on pip.

fruitbat should still install correctly without pybind11 even though it displays an error warning.

zingale commented 5 years ago

okay. thanks.