abatten / fruitbat

A fast radio burst (FRB) redshift estimation package written in Python.
https://fruitbat.readthedocs.io
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

comoving distance differs from docs #31

Closed zingale closed 5 years ago

zingale commented 5 years ago

Working through:

https://fruitbat.readthedocs.io/en/latest/user_guide/using_fruitbat.html

when I get to "Calculating Distances" and the first subsection, "Comoving Distance", I get

In [22]: frb.calc_comoving_distance()                                                                 
Out[22]: <Quantity 1812.21526231 Mpc>

instead of the 2020.297 value reported. Once I create the next frb object in the code block below this, if I go back and look at calc_comoving_distance() I get the value in the docs. So perhaps the docs were executed out of order?

abatten commented 5 years ago

Ahh, I think at one point I wrote luminosity distance before the comoving distance and I rearranged then to be in alphabetical order which causes that mistake. This should be a simple fix, I'll add the same code from luminosity distance to the comoving distance section.

abatten commented 5 years ago

This has been fixed in #33.