search

abb128 / LiveCaptions

Linux Desktop application that provides live captioning
GNU General Public License v3.0
1.15k stars 31 forks source link

Configurable border width #64

Closed miloslavnosek closed 1 year ago

miloslavnosek commented 1 year ago

The default border width for the caption window seems too large. I would welcome a possibility to be able to configure it.

abb128 commented 1 year ago

The border width is 1 pixel at 100% scaling, it was added due to https://github.com/abb128/LiveCaptions/issues/9. I think a setting for this would be too minor and would just add to settings menu bloat

whitequark commented 1 year ago

The border looks like this for me, not sure why:

Screenshot_20230531_103325

That's a lot more than (scaling factor) pixels, which should be at most 2 for me.

miloslavnosek commented 1 year ago

The border looks like this for me, not sure why:

Screenshot_20230531_103325

That's a lot more than (scaling factor) pixels, which should be at most 2 for me.

That's exactly how it looks for me too. I was under the impression that this was by design.

I'm not sure what could be causing it. I'm on i3wm, and I'm just using the flatpak version 0.4.0.

whitequark commented 1 year ago

I'm on i3wm, and I'm just using the flatpak version 0.4.0.

Same setup here.

abb128 commented 1 year ago

This seems to be the solid-csd class that GTK adds when it determines the compositor doesn't support window shadows. It's normally supposed to look like this. image

I can't seem to affect solid-csd by defining my own styles for .solid-csd in style.css but putting gtk_widget_remove_css_class(GTK_WIDGET(self), "solid-csd"); in livecaptions-window initializer seems to be an ugly fix

abb128 commented 1 year ago

I added the fix to 3b0a8c85cafcf9e32c6e33214b8bd54491f63740 since I couldn't find a better workaround

whitequark commented 1 year ago

This addresses the issue for me, thanks!