search

abba23 / spotify-adblock-linux

Spotify adblocker for Linux
GNU General Public License v3.0
721 stars 68 forks source link

Ads still playing, just less frequent (banner ads are not displayed) #31

Closed kerbless closed 4 years ago

kerbless commented 4 years ago

spotify-client (1:1.1.10.546.ge08ef575-19)

Installed via the official repository. Running on Debian 10 with Gnome. One ad provider: https://ad.doubleclick.net/

output of "sudo make --debug install": GNU Make 4.2.1 Built for x86_64-pc-linux-gnu Copyright (C) 1988-2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Reading makefiles... Updating makefiles.... Updating goal targets.... File 'install' does not exist. Must remake target 'install'. install -Dm644 -t /usr/local/lib spotify-adblock.so Successfully remade target file 'install'.

output of "LD_PRELOAD=/usr/local/lib/spotify-adblock.so spotify": [1125/172058.267787:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command

abba23 commented 4 years ago

output of "D_PRELOAD=/usr/local/lib/spotify-adblock.so spotify"

The environment variable is called LD_PRELOAD.

kerbless commented 4 years ago

output of "D_PRELOAD=/usr/local/lib/spotify-adblock.so spotify"

The environment variable is called LD_PRELOAD.

Just a typing error sorry. Spotify runs as expected, the output is the same.

abba23 commented 4 years ago

Then please try removing the spotify-adblock.so file from the build directory and run sudo make install again. As long as the file still exists, make won't try to rebuild it, which seems to have happened when you just ran it.

I'm not sure why banner ads aren't appearing for you though. If anything had been blocked there should have been some corresponding terminal output.

kerbless commented 4 years ago

unistalled and reinstalled, now when I run "LD_PRELOAD..." I get this: ERROR: ld.so: object '/usr/local/lib/spotify-adblock.so' from LD_PRELOAD cannot be preloaded (invalid ELF header): ignored. ERROR: ld.so: object '/usr/local/lib/spotify-adblock.so' from LD_PRELOAD cannot be preloaded (invalid ELF header): ignored. ERROR: ld.so: object '/usr/local/lib/spotify-adblock.so' from LD_PRELOAD cannot be preloaded (invalid ELF header): ignored. [1126/133634.614051:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command

abba23 commented 4 years ago

Were there any errors during compilation?

kerbless commented 4 years ago

No

On Tue, 26 Nov 2019, 13:43 abba23, notifications@github.com wrote:

Were there any errors during compilation?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abba23/spotify-adblock-linux/issues/31?email_source=notifications&email_token=AHW4EIUIYECOUZF3HS6FHPDQVUKYBA5CNFSM4JRLNAXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF33WQ#issuecomment-558611930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHW4EIQJOBKCRYAVMGGQYO3QVUKYBANCNFSM4JRLNAXA .

abba23 commented 4 years ago

unistalled and reinstalled

Just to make sure, you did actually remove the spotify-adblock.so file from the build directory and didn't just run sudo make uninstall and sudo make install, right?

If that's the case and there were no errors at all, then I have no idea what the problem could be. Maybe try cloning the repo again to a different folder and building from there. If that doesn't work, I can't really help you any further.

kerbless commented 4 years ago

Tried both ways. No compilation errors, but I get that messages when I run the DL command

On Tue, 26 Nov 2019, 14:06 abba23, notifications@github.com wrote:

unistalled and reinstalled

Just to make sure, you did actually remove the spotify-adblock.so file from the build directory and didn't just run sudo make uninstall and sudo make install, right?

If that's the case and there were no errors at all, then I have no idea what the problem could be. Maybe try cloning the repo again to a different folder and building from there. If that doesn't work, I can't really help you any further.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abba23/spotify-adblock-linux/issues/31?email_source=notifications&email_token=AHW4EISZLYMCO77MN736NG3QVUNNZA5CNFSM4JRLNAXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF5YPQ#issuecomment-558619710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHW4EISBFH6MJAADVFHCFR3QVUNNZANCNFSM4JRLNAXA .

kerbless commented 4 years ago

Fixed: I removed and resinstalled libcurl4-openssl-dev. I ran sudo make uninstall and then make clean. Then I reinstalled with sudo make install and started working.

Edit: I had to add this to my whitelist.h to make songs load:

{ //Added by me "audio-.spotifycdn.net", "audio-fa.scdn.co", "audio-sp-fra2-13.spotifycdn.net", "audio4-ak.spotify.com.edgesuite.net", // "ap.spotify.com", // audio (access point) ".ap.spotify.com", // resolved access points "apresolve.spotify.com", // access point resolving ...

This issue is similar to this one so maybe you can add those servers to the default whitelist?