search

abba23 / spotify-adblock

Adblocker for Spotify
https://github.com/abba23/spotify-adblock
1.89k stars 93 forks source link

pop-up ads #21

Closed ashy1227 closed 3 years ago

ashy1227 commented 3 years ago

would it be possible to get rid of these too?

abba23 commented 3 years ago

I don't remember seeing any pop-up ads myself, but if they're currently getting through, then it's unlikely that they can be blocked with this adblocker (i.e. by blocking access to domains and URLs). You could probably do it in a similar way to what is outlined in #12 though.

Edit: Untested, but just looking at xpui.js, searching for modal",default:!0 and replacing it with modal",default:false for example might work.

liukliukliuk commented 3 years ago

same here

ashy1227 commented 3 years ago

I don't remember seeing any pop-up ads myself, but if they're currently getting through, then it's unlikely that they can be blocked with this adblocker (i.e. by blocking access to domains and URLs). You could probably do it in a similar way to what is outlined in #12 though.

Edit: Untested, but just looking at xpui.js, searching for modal",default:!0 and replacing it with modal",default:false for example might work.

really sorry, realized i had the regular spotify pinned to my dock and was using that instead. i'll close the issue