search

abbasnaqdi / nekoray-macos

This script is made to build https://github.com/MatsuriDayo/nekoray software for use on macOS operating system.
614 stars 54 forks source link

Reduce support to 10.9 and support automatic build for every night at 12.00 #7

Closed Stevemoretz closed 1 year ago

Stevemoretz commented 1 year ago

You can see how it works where there is a new tag available: https://github.com/Stevemoretz/nekoray-macos/actions/runs/4723476018/jobs/8379478797

And how it just skips the build when there is no newer version available: https://github.com/Stevemoretz/nekoray-macos/actions/runs/4723476018/jobs/8380285519

Latest tag on MatsuriDayo/nekoray: 2.25
Latest tag on this repository: 2.25
Latest tags match! Aborting workflow.

This will run every night at 12.00 and if there is any newer tag available at https://github.com/MatsuriDayo/nekoray it will automatically create the MacOS versions for it, it's as simple as that.

abbasnaqdi commented 1 year ago

I read all your descriptions in your Pull Request comments I agree with the general work, and it was done. https://github.com/aaaamirabbas/nekoray-macos/pull/5

But there is also a scenario that needs to be considered. Suppose the last tag, for example, is 2.25 and this version is one with the original release, so everything is okay but here: If the version that is made has bugs, the new version with the same tag should be replaced (so that is not possible at the moment). So if this bug arises, after modifying the script, I have to manually delete the tag and the rails so that the GitHub can recover the new version.

To fix this problem, either a new tag should be added after each script is changed or the previous tag should be deleted. Do you have a scenario or solution for this?

Stevemoretz commented 1 year ago

I read all your descriptions in your Pull Request comments I agree with the general work, and it was done. #5

But there is also a scenario that needs to be considered. Suppose the last tag, for example, is 2.25 and this version is one with the original release, so everything is okay but here: If the version that is made has bugs, the new version with the same tag should be replaced (so that is not possible at the moment). So if this bug arises, after modifying the script, I have to manually delete the tag and the rails so that the GitHub can recover the new version.

To fix this problem, either a new tag should be added after each script is changed or the previous tag should be deleted. Do you have a scenario or solution for this?

I think I got what you mean, Are you saying it's easier instead of manually removing the tag and release, the CI handle should do the replacement automatically on pushes?

Stevemoretz commented 1 year ago

I read all your descriptions in your Pull Request comments I agree with the general work, and it was done. #5

But there is also a scenario that needs to be considered. Suppose the last tag, for example, is 2.25 and this version is one with the original release, so everything is okay but here: If the version that is made has bugs, the new version with the same tag should be replaced (so that is not possible at the moment). So if this bug arises, after modifying the script, I have to manually delete the tag and the rails so that the GitHub can recover the new version.

To fix this problem, either a new tag should be added after each script is changed or the previous tag should be deleted. Do you have a scenario or solution for this?

Your concerns are addressed at : https://github.com/aaaamirabbas/nekoray-macos/pull/10