search

abbaye / WpfHexEditorControl

Wpf Hexeditor is a powerful and fully customisable user control for editing file or stream as hexadecimal, decimal and binary. Can be used in Wpf or WinForm application
https://www.nuget.org/packages/WPFHexaEditor/
Apache License 2.0
815 stars 136 forks source link

Read only label is not affected by status bar visibility #79

Closed Filipsi closed 3 years ago

Filipsi commented 4 years ago

Describe the bug Label indicating that editor is in "read only" mode is not affected by status bar visibility and creates empty space if shown.

To Reproduce

  1. Set StatusBarVisibility property to "Collapsed"
  2. Set ReadOnlyMode property to "True"

Expected behavior Currently, the "read only" label is not part of the status bar. In my opinion, this is incorrect since read only mode is a "status" of the editor. It would be helpful to move it to the status bar, since it would allow it to be hidden. As a side effect, it would also probably resolve positioning issues simar to ones described in issue #74.

Alternatively, if it's not possible to change editor layout, it would be helpful to at last have property to control it's visibility.

Screenshots Read only mode disabled with status bar collapsed example1

Read only mode enabled with status bar collapsed example2

Desktop:

abbaye commented 4 years ago

Oupssi will correct this :sweat_smile: