abbbe / sslcaudit

Other
28 stars 14 forks source link

Sslcaudit exits with an error when no CA certificate is provided in command line #50

Open gremwell opened 10 years ago

gremwell commented 10 years ago

Running sslcaudit without parameters: alla@moggy:~/sslcaudit$ bin/sslcaudit Traceback (most recent call last): File "bin/sslcaudit", line 114, in sys.exit(main(sys.argv)) File "bin/sslcaudit", line 100, in main ui = SSLCAuditCLI(options, file_bag) File "bin/../sslcaudit/ui/SSLCAuditCLI.py", line 23, in init self.controller = BaseClientAuditController(self.options, file_bag, event_handler=self.event_handler) File "bin/../sslcaudit/core/BaseClientAuditController.py", line 41, in init self.init_profile_factories() File "bin/../sslcaudit/core/BaseClientAuditController.py", line 75, in init_profile_factories self.profile_factories.append(profile_factory_class(self.file_bag, self.options)) File "bin/../sslcaudit/modules/sslcert/ProfileFactory.py", line 82, in init self.add_profiles() File "bin/../sslcaudit/modules/sslcert/ProfileFactory.py", line 139, in add_profiles self.add_im_basic_constraints_profiles() File "bin/../sslcaudit/modules/sslcert/ProfileFactory.py", line 151, in add_im_basic_constraints_profiles self.add_im_basic_constraints_profile(cert_req, basicConstraint_CA=None) File "bin/../sslcaudit/modules/sslcert/ProfileFactory.py", line 201, in add_im_basic_constraints_profile ca_cn = ca_certnkey.cert.get_subject().CN AttributeError: 'NoneType' object has no attribute 'cert'

Running it with ca certificate given in command line: alla@moggy:~/sslcaudit$ bin/sslcaudit --user-ca-cert test/certs/test-ca-cacert.pem --user-ca-key test/certs/test-ca-cakey.pem 2014-09-11 10:05:18,290 BaseClientAuditController INFO number of profile factories: 1 2014-09-11 10:05:18,290 BaseClientAuditController INFO profile factory: SSLCert (5 profiles) 2014-09-11 10:05:18,290 SSLCAuditCLI INFO filebag location: sslcaudit.8 2014-09-11 10:05:18,291 ClientAuditorTCPServer INFO listen_on: ('0.0.0.0', 8443)

Starts successfully.

Expected behaviour: picks up or generates CA certificates automatically when none specified in command line.