Local backup being detected as remote, fails

[dopplet]

Upgraded from 1.9.42 to 2.6

Version used Provide output of virtnbdbackup -V

2.6

Describe the bug

Executing "virtnbdbackup -d DOMAIN -l auto -o /mnt/D7040S-001/vm_backups/2024-04/DOMAIN" results in attempting to perform a remote backup instead of a local backup.

This worked fine with 1.9.42

Expected behavior Backup occurs locally and does not try and use SSH.

Hypervisor information:

• OS: Debian
• HV type: libvirt

Logfiles: [2024-04-05 11:55:32] INFO lib common - printVersion [main]: Version: 2.6 Arguments: /usr/bin/virtnbdbackup -d DEB64-DOCKER-001 -o /mnt/D7040S-001/vm_backups/2024-04/DEB64-DOCKER-001/ [2024-04-05 11:55:32] INFO root virtnbdbackup - main [main]: Backup level: [copy] [2024-04-05 11:55:32] INFO virt client - _connect [main]: Connected to remote host: [D7040S-001], local host: [D7040S-001.lan] [2024-04-05 11:55:32] INFO root virtnbdbackup - main [main]: Libvirt library version: [9000000] [2024-04-05 11:55:32] INFO root virtnbdbackup - main [main]: NBD library version: [1.14.2] [2024-04-05 11:55:32] INFO root virtnbdbackup - main [main]: Backup will save [1] attached disks. [2024-04-05 11:55:32] INFO root virtnbdbackup - main [main]: Concurrent backup processes: [1] [2024-04-05 11:55:32] INFO root checkpoint - create [main]: Loading checkpoints from: [/mnt/D7040S-001/vm_backups/2024-04/DEB64-DOCKER-001//DEB64-DOCKER-001.cpt] [2024-04-05 11:55:32] INFO root checkpoint - redefine [main]: Loading checkpoint list from: [/mnt/D7040S-001/vm_backups/2024-04/DEB64-DOCKER-001//checkpoints] [2024-04-05 11:55:32] INFO root checkpoint - create [main]: Checkpoint handling. [2024-04-05 11:55:32] INFO ssh client - connect [main]: Connecting remote system [D7040S-001] via ssh, username: [root]

[2024-04-05 11:55:32] INFO paramiko.transport transport - _log [Thread-1]: Authentication (publickey) failed. [2024-04-05 11:55:32] WARNING lib common - sshSession [main]: Failed to setup SSH connection: [SSH key authentication failed: Authentication failed.] [2024-04-05 11:55:32] ERROR root virtnbdbackup - main [main]: Remote backup detected but ssh session setup failed

Workaround: Have not found any.

[abbbi]

hm.. its detected as remote backup because hostnames differ:

[2024-04-05 11:55:32] INFO virt client - _connect [main]: Connected to remote host: [D7040S-001], local host: [D7040S-001.lan]

[abbbi]

i changed the code to use gefqdn() instead of gethostname() recently which might have introduced the issue just reverted the code to use gethostname again, please try with latest master version.

Update: should be fixed as with 2.7

[dopplet]

Thanks for this, backup worked using the 2.7 release you just did.