abbbi / virtnbdbackup

Backup utility for Libvirt / qemu / kvm supporting incremental and differential backups + instant recovery (agentless).
http://libvirtbackup.grinser.de/
GNU General Public License v3.0
330 stars 46 forks source link

Debug option --printonly make backup in auto mode #189

Closed sikorapatryk closed 2 months ago

sikorapatryk commented 2 months ago

Version used 2.10

Describe the bug Invoking a command: virtnbdbackup --printonly -d vm01 -l auto -o /backup/vm01/$(date +"%Y/%U") --scratchdir /backup/vm01 -i vda --freeze-mountpoint / --noprogress --compress --nocolor when the target folder -o /backup/vm01/$(date +"%Y/%U") is empty causes the full backup to be started.

Expected behavior Information about the size of the full backup or a warning that there is no backup in the target location yet should be displayed.

Hypervisor information:

abbbi commented 2 months ago

hi,

--printonly can only work if there is already an checkpoint existant, to estimate the backup size of an incremental or differencial backup, so it requires an full backup beforehand. The check involves if there is an parent checkpoint:

if args.printonly and args.cpt.parent and not args.offline:

args.cpt.parent doesnt exist in this case thus its executing an backup.

The function cant estimate the size of a full backup, only the size of an incremental or a differential backup. I think behavior is OK for auto backup function: its better to create an backup than not in this case.

Updated README to be more specific.

Thanks