abbi031892 / periscope

Automatically exported from code.google.com/p/periscope
0 stars 0 forks source link

Periscope never finds subs on bierdopje #66

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. downloaded trunk via SVN
2. excluded all search engines, except bierdopy
3. ran the bin/periscope script.

What is the expected output? What do you see instead?

it does not find any subs on bierdopje, whilst a manuel check on 
www.bierdopje.com shows that they are there.

ran it again with the --debug option and found out the following:

DEBUG:root:possible langs : ['nl'] 
DEBUG:root:Looking for show Id @ 
http://api.bierdopje.com/23459DC262C0A742/GetShowByName/show%20name%20-

When I tried this url manually, it gives a false. But then I saw the trailing 
%20 and dash. All my episodes are in the following format: Show Name - SXXEYY - 
Episode Name.avi

I tried the api url without the trailing chars and then I got the correct 
result from Bierdopje.

So just for testing, I changed the file name of one episode to Show 
Name.SXXEYY.Episode Name.avi.

I ran the script again: 

INFO:root:Searching on BierDopje 
DEBUG:root:possible langs : ['nl'] 
DEBUG:root:Looking for show Id @ 
http://api.bierdopje.com/23459DC262C0A742/GetShowByName/Show%20Name
DEBUG:root:Found id : xxxxx
DEBUG:root:Looking for subs @ 
http://api.bierdopje.com/23459DC262C0A742/GetAllSubsFor/xxxxx/1/1/nl
DEBUG:root:Release found : Show.Name.s01e01.dvdrip.xvid-schizo
DEBUG:root:Searching for : Show Name.s01e01.Episode Name
DEBUG:root:Release found : Show.Name.s01e01.dvd.rl.hdtv.srt
DEBUG:root:Searching for : Show Name.s01e01.Episode Name
INFO:root:BierDopje writing 0 items to queue

So now it detects the show and continues its search. It finds the subs, but 
does not download them ?

What version of the product are you using? On what operating system?

SVN trunk on NSLU2

Please provide any additional information below.

Original issue reported on code.google.com by tom.mich...@gmail.com on 18 Jan 2011 at 4:12

GoogleCodeExporter commented 8 years ago
periscope tries to match releases in order to make sure you get the right 
subtitle, the concept is more "if I find one, I'm sure it's a good one" than a 
"I'll find you something, anything".

If you rename your files, you remove some useful info that the script uses to 
find the matching subtitle.

One suggested option has been to find back the release info using 
OpenSubtitles. But I have exams in January (and one tomorrow :P) so that is not 
on my priority list right now.

Another thing in the debug lines is that the dvd.rl.hdtv release still has the 
".srt" part, there is another bug open about that, I'll remove the .srt when 
found.

If you could mail me the original file name and the modified file name ( 
admin@getmesubs.com ) so that I can try to include it in my unit tests.

Original comment by patrick....@gmail.com on 18 Jan 2011 at 4:20

GoogleCodeExporter commented 8 years ago
Thanks, I've send you an email.

Would it be possible to implement something to force downloading a subtitle as 
90% of the time these subs are ok for me?

Original comment by tom.mich...@gmail.com on 18 Jan 2011 at 4:30

GoogleCodeExporter commented 8 years ago
I'm having the same issue.
I'm 100% certain the filenames are original and matches the ones used on 
Bierdopje.com

I'm running windows converted version and on latest svn.

If needed i can send debug log.

Original comment by whocarez2k5@gmail.com on 31 Jan 2011 at 12:18

GoogleCodeExporter commented 8 years ago
I've added the line in r126 to not take the .srt into account.

Could you guys test it with the latest from SVN and tell me if it's still not 
downloading the file for you ?

If not, could you put here (or mail me at admin@getmesubs.com ) the files 
you're trying to download subtitles for ?

Original comment by patrick....@gmail.com on 1 Feb 2011 at 8:28

GoogleCodeExporter commented 8 years ago
Patrick, I just send you an email.

When the filenames do not match completely, could you add an option to force 
download what is available? 

Original comment by tom.mich...@gmail.com on 1 Feb 2011 at 9:04

GoogleCodeExporter commented 8 years ago
Maybe an good idea is when there is no complete match to search for 
releasegroup.

Sometimes there is within the name also the title of the episode which is not 
usefull normally so only the releasegroup would be a good idea which is 
normally the last part of the filename before the extension seperated with an -

Original comment by rikustha...@gmail.com on 18 May 2011 at 3:20

GoogleCodeExporter commented 8 years ago
The release group approach is done on other plugins, when the source does not 
provide a filename. I will look into what BierDopje provides an maybe look into 
making a fallback on release groups more generic. But it's not a priority.

By the way, I've pushed a new version on SVN yesterday. It should fix BierDopje 
for those that use a Freedesktop compatible desktop (Gnome, KDE, XFCE, ...) and 
have python-xdg installed.

Original comment by patrick....@gmail.com on 18 May 2011 at 3:24

GoogleCodeExporter commented 8 years ago

Original comment by patrick....@gmail.com on 24 Feb 2013 at 12:13