search

abbot / go-http-auth

Basic and Digest HTTP Authentication for golang http
Apache License 2.0
544 stars 121 forks source link

BasicAuth needs to support all bcrypt prefixes #35

Closed JMelbyClypd closed 8 years ago

JMelbyClypd commented 8 years ago

The code as currently written only detects the bcrypt prefix "$2y$"; it should also handle "$2a$" and "$2b$". Please see https://en.wikipedia.org/wiki/Bcrypt.

abbot commented 8 years ago

Wikipedia is not a good source to cite for such issues, but there is some explanation in crypt(3) from crypt_blowfish source.

Fixed in 7eb3526, see also that commit for more details.