search

abbysmal / Canopy

A git-blogging unikernel written using MirageOS
ISC License
120 stars 27 forks source link

feature: articles with `redirect: /Page` will redirect to specified page #74

Closed gjaldon closed 8 years ago

gjaldon commented 8 years ago

Closes #73

Thanks a lot for the help, @hannesm!! My first ever OCaml open-source contribution!!! 🙇 🎆

gjaldon commented 8 years ago

@hannesm I just applied the change you suggested. :)

hannesm commented 8 years ago

great, thanks! :)

gjaldon commented 8 years ago

my pleasure 🙇

hannesm commented 7 years ago

thanks again for your contribution, I now use this on https://hannes.nqsb.io (now having an /About and /Posts/About redirecting there). I did minor modifications to your implementation, https://github.com/Engil/Canopy/commit/eb41a0c1aa88b47fd54b30754ccc0dce49260b02, namely adding the ~sep label to have OCaml not complain, and String.trim the value of the redirect.

and on top of that https://github.com/Engil/Canopy/commit/b93dad3591a1d1edfbd998dc651b7a44ea8a416a to separate the concerns a bit stricter..

gjaldon commented 7 years ago

That's great you're already using the feature! :) Will try migrating my blog over to Canopy on my next weekend just to try out mirage in 'prod'.

Thanks for sharing the modifications you did. Should've noticed the warning and the other commit was particularly useful as reference for good style.