Avoid warning: use Cohttp_lwt.S.Server

abbysmal / Canopy

A git-blogging unikernel written using MirageOS

ISC License

120 stars 27 forks source link

Avoid warning: use Cohttp_lwt.S.Server #91

Closed olleolleolle closed 7 years ago

olleolleolle commented 7 years ago

This avoids a warning when using Cohttp_lwt.Server

File "canopy_dispatch.ml", line 10, characters 16-33:
Warning 3: deprecated: Cohttp_lwt.Server
Use Cohttp_lwt.S.Server

abbysmal commented 7 years ago

Thank you for your patch! I am not up to date regarding latest Cohttp developments, it seems that this module is not just a relocation of the old functor but another implementation altogether. I will try to look it up, but if it was tested and @hannesm has nothing to say against it I suppose we can merge. :)

hannesm commented 7 years ago

LGTM!

hannesm commented 7 years ago

thanks for this contribution, sorry for the late merge.