abcd-j / data-catalog

https://data.abcd-j.de
0 stars 1 forks source link

Show shortened format for DOI and License, not full URL #26

Closed tmheunis closed 3 months ago

tmheunis commented 6 months ago

Feedback from @mih:

image

jsheunis commented 6 months ago

DOI can be handled in the catalog javascript, it is already done correctly for publication doi. I.e. no need to change catalog entry code.

The license format is already

{
   "name": "",
   "url": ""
}

and rendered as <a href="license-url">license-name</a> in the catalog, so this will have to be updated in catalog-generating code (for future cases) and catalog metadata (for current case).

jsheunis commented 6 months ago

Turns out the dataset doi is already handled, it's just that it doesn't account for the www because the url is typically https://doi.org/ without the www

jsheunis commented 6 months ago

Plan is to fix both issues by fixing catalog metadata, and then introduce code functions or checks to fix future occurrences of new metadata entries

tmheunis commented 5 months ago

This has now been fixed in the ABCD-J catalog. @jsheunis should I keep the issue open?

tmheunis commented 3 months ago

I will close this, and we can reopen if the issue jumps out again.