abcdesktopio / pyos

abcdesktop API services
https://abcdesktopio.github.io/
GNU General Public License v2.0
2 stars 2 forks source link

"local variable 'ka' referenced before assignment" #7

Closed spijker closed 1 year ago

spijker commented 1 year ago

Running in kubernetes v 1.23 Now some applications are working just fine, like gimp , writer and firefox. But when I download chrome.d or vlc.d , and tru to start the application I always get an error "local variable 'ka' referenced before assignment"

2022-10-28 07:17:09 od [INFO ] __main__.trace_response:105011976393936995324 /composer/listsecrets {'status': 200, 'result': [], 'message': 'ok'} 2022-10-28 07:17:09 orchestrator [INFO ] oc.od.orchestrator.ODOrchestratorKubernetes.findDesktopByUser:105011976393936995324 Pod is found 105011976393936995324-eaccf3e8-1eea-4eae-a7f1-410ce792bb21 2022-10-28 07:17:09 composer [DEBUG ] oc.od.composer.openapp:105011976393936995324 no application instance abcdesktopio/chrome.d:latest is running, create a new one 2022-10-28 07:17:09 infra [INFO ] oc.od.infra.selectInfra:105011976393936995324 infra mode is kubernetes 2022-10-28 07:17:09 infra [INFO ] oc.od.infra.ODInfraKubernetes.__init__:105011976393936995324 rio 2022-10-28 07:17:09 infra [INFO ] oc.od.infra.ODInfraKubernetes.__init__:105011976393936995324 nodehostname=rio 2022-10-28 07:17:09 infra [INFO ] oc.od.infra.ODInfraKubernetes.getdockerClient:105011976393936995324 Creating client: base_url = 'tcp://rio:2375' 2022-10-28 07:17:09 composer_controller [ERROR ] controllers.composer_controller.ocrun:105011976393936995324 local variable 'ka' referenced before assignment 2022-10-28 07:17:09 od [INFO ] __main__.trace_response:105011976393936995324 /composer/ocrun {'status': 500, 'result': None, 'error': "local variable 'ka' referenced before assignment"}

alexandredevely commented 1 year ago

Hello,

I confirm this issue. The documentation page is wrong, it must set the abcdesktop tag to 1.0 for application format 1.0, and it use by default the latest format. I'm sorry.

To fix this issue

docker rmi  abcdesktopio/vlc.d:latest
docker pull abcdesktopio/vlc.d:1.0
docker rmi abcdesktopio/chrome.d:latest
docker pull abcdesktopio/chrome.d:1.0

I've updated the script on page applications/list

wget -O images-list.txt https://raw.githubusercontent.com/abcdesktopio/conf/main/images-list.txt
while read i; do
        docker pull abcdesktopio/$i:1.0
done < images-list.txt

Thank you for this issue

Alexandre

alexandredevely commented 1 year ago

This issue has been fixed in abcdesktopio/oc.pyos:1.2 You can replace abcdesktopio/oc.pyos:1.0 by abcdesktopio/oc.pyos:1.2 Thank you for you feedback Alexandre

spijker commented 1 year ago

Thx , after the update , the problem is gone !