abcminiuser / dmbs

Dean's Makefile Build System - making MAKE easier.
51 stars 18 forks source link

Repair LTO option for linker #36

Closed dudanov closed 6 years ago

NicoHood commented 6 years ago

Why did you move the LTO option further down?

dudanov commented 6 years ago

Because BASE_LD_FLAGS is reassigned below. Look closely. ;)

NicoHood commented 6 years ago

True! It still worked for me always... (it was my patch). I am wondering why!? Or maybe some newer patches changed the behavior? Or LD flags are not even required?

dudanov commented 6 years ago

It is a link-time optimization option (LTO). Usually it is not required. And by default it's off. I accidentally discovered an error. So I decided if there is a mistake, then there must be a correction.

I add bootloader support option. Easy to use.

abcminiuser commented 6 years ago

The LTO fix is a good one! Can you please split the other change into its own pull request, so they can be merged separately?

dudanov commented 6 years ago

New pull-request created.