Closed kidbomb closed 6 years ago
Hey @abcminiuser got a chance to look into this patch?
Not yet, I just got back from a two week business trip to the US a few hours ago - will give it a look once I'm over the 17 hour timeshift.
Just rebased/squashed my commits with my code review changes.
Looking decent now, I just have to find time to reformat it and fully integrate it. Sorry, I know it's been a slow process - me being out of the country for two weeks hasn't helped, and right now a bunch of my stuff is in boxes for the impending home move.
I'll do this as soon as I can, hopefully won't be too much longer. If I have time this week after work I'll give it a go.
Hey @abcminiuser got a chance to take a look into this already?
A rather long afternoon of merging, squashing, rebasing, reformatting and more and I've got a minimal feature-ccid
branch now with all the changes. I think this is pretty much ready to go, minus some small last changes I need from you:
1) I need descriptions for the callbacks in LUFA\Drivers\USB\Class\Device\CCIDClassDevice.h
that aren't currently documented. Can you please add these, including the return codes and parameter descriptions (see the functions above it for examples.
2) The CALLBACK_CCID_XfrBlock
callback doesn't seem to be used, and there's a TODO:
in the handing for that request in LUFA\Drivers\USB\Class\Device\CCIDClassDevice.c
. Should the callback be called there?
3) Same deal with the low level device demo, there's a TODO:
still in the XfrBlock message handling.
Once those are sorted this is ready for merge. Since this is a squashed branch I recommend you move your existing branch to another name, and diff it against the upstream feature branch to make sure I didn't mess anything up or miss any of your changes.
Just checked it now - I added the requested documentation and removed the XfrBlock callbacks for now. As soon as I get the right design for it I can create a review for it separately.
Added const qualifiers, context parameters to the CCID device driver callbacks and some additional reformatting to match existing code style.