search

abcminiuser / lufa

LUFA - the Lightweight USB Framework for AVRs.
http://www.lufa-lib.org
1.04k stars 325 forks source link

Enable LED3 and LED4 for the A3BU_XPLAINED board #2

Closed jamuraa closed 11 years ago

jamuraa commented 11 years ago

LED3 is the red LED in the status LED LED4 is the green LED in the status LED

They're arbitrary, but this order makes the USB_ERROR and USB_READY masks in most of the demos light the red for error and green for ready, which seems preferable.

I noticed that there is another pull request that you mentioned you couldn't do anything with because the github is a svn mirror. Is there a better way to submit patches? :smile:

abcminiuser commented 11 years ago

Thanks for the patch Michael! I've cleaned it up and extended it a bit, and applied it to this commit rather than merging it directly:

https://github.com/abcminiuser/lufa/commit/16037433a2caf0c93b811b774a9ea5fd1324514e

Thus, I am closing this request. Looks like I missed the status bi-color LED on the new XMEGA C3 Xplained board as well.

The Github LUFA repository here is now the primary revision control location for LUFA, as I have discontinued the public SVN and migrated entirely to Git locally. This means I am now able to accept pull requests, however I tend to favour manual tweaking and patching where possible to ensure the code style remains consistent and the patches are complete.