LUFA-111009 download from github seems wrong

[DavidEGrayson]

I get significantly different versions of LUFA-111009 depending on where I download it from.

If I download LUFA-111009.zip from googlecode.com, it has a sha1sum of fe6abf1cef6fb924d58f9158c5297e305b169a8f and it defines ENDPOINT_DIR_IN to be 0x80 in USBController.h:

/** Endpoint address direction mask for an IN direction (Device to Host) endpoint. This may be ORed with
 *  the index of the address within a device to obtain the full endpoint address.
 */
#define ENDPOINT_DIR_IN                    0x80
//@}

If I go to LUFA on fourwalledcubicle.com, the link for LUFA-111009 points to http://www.github.com/abcminiuser/lufa/archive/LUFA-111009.zip, which means I get the files in the commit tagged with LUFA-111009. Currently the LUFA-111009 tag points at commit https://github.com/abcminiuser/lufa/commit/b838991e4a927b65fbd32d2596b5f48cac2b65c8, which defines ENDPOINT_DIR_IN to be 0x01 in Endpoint_AVR8.h:

/** Endpoint data direction mask for \ref Endpoint_ConfigureEndpoint(). This indicates that the endpoint
 *  should be initialized in the IN direction - i.e. data flows from device to host.
 */
#define ENDPOINT_DIR_IN                         (1 << EPDIR)
//@}

I think the git tag for LUFA-111009 was placed on the wrong commit. Perhaps it should be moved from https://github.com/abcminiuser/lufa/commit/b838991e4a927b65fbd32d2596b5f48cac2b65c8 to either https://github.com/abcminiuser/lufa/commit/c5a05edd8f3a742039e99b06ea7ee172fad70bf3 or https://github.com/abcminiuser/lufa/commit/beb069b9b845da02de07e4e3e0149e84004d2445, since both of those claim to be the "Commit for the 111009 release.".

Regardless of where the git tag points to, I would suggest that the link on fourwalledcubicle.com should point to the original LUFA-111009.zip (which has a sha1sum of fe6abf1cef6fb924d58f9158c5297e305b169a8f). The reason is that the top-level folder in your original ZIP file is named "LUFA-111009" but the ZIP file created by github uses "lufa-LUFA-111009" instead. This difference makes it hard for people to communicate about LUFA-111009 and write correct instructions for how to extract it and use it. Old instructions that were based on the original ZIP file will generally not work.

[abcminiuser]

Hi David,

Sorry, didn't notice the issue report in my inbox before now. I'll take a look at this and see if I can correct the tag pointer; there should be a single commit that definitively defines a particular release, as I follow a tag-zip-build-release methodology.

Since Google Code is now useless and my own hosting has limited bandwidth, the GitHub autogenerated zips are the next best thing I have to the old zip release attachments. If your instructions refer to the exact naming of the release please just link people to the mirror on my own site (http://www.fourwalledcubicle.com/files/LUFA/LUFA-111009.zip) which is an exact duplicate of the Google Code releases.

[abcminiuser]

Tag corrected to beb069b9b845da02de07e4e3e0149e84004d2445 - if this is still incorrect, please re-open the issue. Thanks!