Fix missing report IDs in feature reports

abcminiuser / lufa

LUFA - the Lightweight USB Framework for AVRs.

http://www.lufa-lib.org

1.04k stars 325 forks source link

Fix missing report IDs in feature reports #28

Closed The-42 closed 10 years ago

The-42 commented 10 years ago

G'day mates,

consider a device with multiple reports and thus requiring report IDs for distinction. While the ID is set for input reports this was not the case with feature reports - they lacked the ID and confused the HID parser. The USB-HID spec says an ID has to be sent when using multiple reports without stating an exclusion for feature reports, so seems like a bug to me.

The commit included in this request fixes this issue and makes the device pass the HID-parser.

abcminiuser commented 10 years ago

Interesting, you are quite correct, and the current code missed sending the ReportID back on all HID GetReport request types. Thanks for the patch!