search

abcminiuser / python-elgato-streamdeck

Python library to control the Elgato Stream Deck.
Other
919 stars 137 forks source link

Refactor _read_key_states into _read_control_states #116

Closed brimston3 closed 1 year ago

brimston3 commented 1 year ago

The updated internal function returns a dictionary with essentially the same data as before, but the device implementation itself is handling report decoding.

While it is possible a future report might contain multiple types of return data, current reports do not on the only device capable of multiple control types.

This commit should bring #108 closer to merge by implementing the first phase of https://github.com/abcminiuser/python-elgato-streamdeck/pull/108#issuecomment-1368328529

abcminiuser commented 1 year ago

Thanks for the patch @brimston3 - sorry for the delay (real life life problems). I'm looking at sourcing a StreamDeck+ now so I can integrate this and some sort of device support in the next version.

abcminiuser commented 1 year ago

Thanks! I meant to get to this sooner, but I've merged a community patch in 56f91960297f753acdaeb79fd460c4326f7c4840.

Unfortunately the StreamDeck + is damned expensive in Australia (and I can't justify the expense for a hobby project) and Corsair told me to shove it when I asked for even temporary access to a unit, so I'm trusting on you and the rest of the community to verify that it works before I tag off the next version for PyPi.

Can you please grab the latest master and verify the example script works on the StreamDeck +?