abcminiuser / python-elgato-streamdeck

Python library to control the Elgato Stream Deck.
Other
919 stars 137 forks source link

feat: enable relative path dll loading for windows #117

Closed Lewiscowles1986 closed 1 year ago

Lewiscowles1986 commented 1 year ago

Hi,

Thanks for authoring this. It is incredibly cool to be able to use python to control a StreamDeck.

I've had issues on every platform I've used this for so far 😅 from building hidapi dynlib on OSX to getting windows to load hidapi.dll without placing in shared folders.

It's a fairly common Workaround for Windows apps to be able to override a system level DLL using one in their present directory. This enables that using this python library, without affecting the rest of the code.

If it works for you, great. If not, I won't be offended. I've tested using all the examples provided. Next up Linux 😅

Thanks again 👋

abcminiuser commented 1 year ago

No objection, this seems like a good idea for projects that want to package up the dependencies as well. Sorry for the late reply!

Lewiscowles1986 commented 1 year ago

Oh it wasn't late. I've had to wait months to get security fixes merged. In OpenSource I expect things to sit for a bit. Thanks for being so prompt, and again for the awesome work.