search

abcnews / covid19-data-import-function

Fetch data and upload to the cloud
https://www.abc.net.au/news/story-streams/coronavirus/
2 stars 0 forks source link

Proposal: protect the master branch #47

Closed drzax closed 2 years ago

drzax commented 2 years ago

Github will now let us protect branches in a variety of ways. For this repository I propose we turn on branch protection for master to avoid an accidental deploy.

I propose we require a pull request with at least two approvals before a merge is allowed.

Let me know what you think.

katiaeirin commented 2 years ago

Branch protection sounds good.

Do you think we need approvals to merge though? I expect most reviews for this repo will be "Looks good if it works" given the purpose of the repo.

A lot of merges are also for issues caused by third party changes and I imagine we want to merge those without having to wait a few days for a review.

phocks commented 2 years ago

Yep. As discussed in the dev chat. Agree with protecting the master branch from direct pushes. But maybe for ease, just because most of the pull requests will be for quick fixes, there is less need for approvals before a merge can happen.

drzax commented 2 years ago

I've turned this on now. Commits to master should have to go through a PR.