abcxyz / abc

Apache License 2.0
12 stars 3 forks source link

chore(deps): bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /t/data_migration_pipeline #481

Closed dependabot[bot] closed 7 months ago

dependabot[bot] commented 7 months ago

Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/abcxyz/abc/network/alerts).
mattrandallbecker commented 7 months ago

@drevell can you get someone to dig in to why these tests failed?

drevell commented 7 months ago

@drevell can you get someone to dig in to why these tests failed?

@mattrandallbecker I actually understand why the golden tests failed. We have templates containing go.mod files, which are visible to dependabot. We have golden-tests for these templates that expect the template to output an exact set of files (including the old/insecure deps). When dependabot updates go.mod, it doesn't know how to also update the expected golden output. So it seems we need manual action (run abc templates golden-test record) to fix golang dependabot issues :/

The particular dependency that's the subject of this PR was just fixed in #495.

I also filed #496 to see if there's a fix for the general problem (dependabot PRs need manual action).

dependabot[bot] commented 7 months ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.