Closed dependabot[bot] closed 7 months ago
@drevell can you get someone to dig in to why these tests failed?
@drevell can you get someone to dig in to why these tests failed?
@mattrandallbecker I actually understand why the golden tests failed. We have templates containing go.mod files, which are visible to dependabot. We have golden-tests for these templates that expect the template to output an exact set of files (including the old/insecure deps). When dependabot updates go.mod, it doesn't know how to also update the expected golden output. So it seems we need manual action (run abc templates golden-test record
) to fix golang dependabot issues :/
The particular dependency that's the subject of this PR was just fixed in #495.
I also filed #496 to see if there's a fix for the general problem (dependabot PRs need manual action).
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show