search

abcxyz / abc

Apache License 2.0
12 stars 3 forks source link

"impossible condition" warning in TestProcessGlobs #508

Closed drevell closed 6 months ago

drevell commented 7 months ago

This line of code is giving a compiler warning of impossible condition: nil != nil: https://github.com/abcxyz/abc/blob/23bee49450c6b00195da7b3c3dc94fbab60703b8/templates/common/render/action_test.go#L543

@kevya-google , as the author of this, do you know what was intended here? It's not immediately clear to me.

sethvargo commented 7 months ago

Looks like this might have been a bad merge conflict resolution (the same stanza is repeated 3 lines up)