abcxyz / abc

Apache License 2.0
12 stars 3 forks source link

Remove Manifest option in favor of SkipManifest #625

Closed drevell closed 2 months ago

drevell commented 2 months ago

Going forward, we want render operations to default to producing a manifest, so they're upgradeable later. Therefore, in the Render() library API, we want to invert to sense of the Manifest bool to SkipManifest so that the default value of false does the desirable default behavior.

This is technically part of an exported API that shouldn't be changed, but since there's only one non-CLI user of this, and he's on our team, we'll allow it to change.

To be consistent with the above, the command line flag also changes from --manifest to --skip-manifest. This is also a backwards-incompatible change, but since the flag is documented as experimental, we'll allow it.

We also update a bunch of tests to assert on the produced manifests.