search

abcxyz / github-metrics-aggregator

Apache License 2.0
11 stars 3 forks source link

Separate github client into new package and add new method #225

Closed stytchiz closed 5 months ago

stytchiz commented 5 months ago

New method calls CreateIssueComment API

The reason to separate this is so that the new teeth CloudRun service can use it to publish github workflow invocation comments to PRs. This avoids code duplication.

This PR should not make any behavior changes in GMA.

➜  github-metrics-aggregator git:(stanchen/teeth-fork) go test ./... && gofumpt -l -w  -extra . && golangci-lint run
?       github.com/abcxyz/github-metrics-aggregator/cmd/github-metrics-aggregator       [no test files]
ok      github.com/abcxyz/github-metrics-aggregator/integration (cached)
?       github.com/abcxyz/github-metrics-aggregator/pipeline/leech      [no test files]
ok      github.com/abcxyz/github-metrics-aggregator/pipeline/review     (cached)
?       github.com/abcxyz/github-metrics-aggregator/pkg/githubauth      [no test files]
ok      github.com/abcxyz/github-metrics-aggregator/pkg/cli     (cached)
?       github.com/abcxyz/github-metrics-aggregator/pkg/githubclient    [no test files]
?       github.com/abcxyz/github-metrics-aggregator/pkg/review/bq       [no test files]
?       github.com/abcxyz/github-metrics-aggregator/pkg/secrets [no test files]
ok      github.com/abcxyz/github-metrics-aggregator/pkg/leech   (cached)
ok      github.com/abcxyz/github-metrics-aggregator/pkg/retry   (cached)
ok      github.com/abcxyz/github-metrics-aggregator/pkg/review  (cached)
?       github.com/abcxyz/github-metrics-aggregator/pkg/version [no test files]
?       github.com/abcxyz/github-metrics-aggregator/protos      [no test files]
?       github.com/abcxyz/github-metrics-aggregator/protos/pubsub_schemas       [no test files]
ok      github.com/abcxyz/github-metrics-aggregator/pkg/teeth   (cached)
ok      github.com/abcxyz/github-metrics-aggregator/pkg/webhook (cached)