abcxyz / github-metrics-aggregator

Apache License 2.0
11 stars 3 forks source link

Switch from usings reviewDecision to reviews #231

Closed lock14 closed 5 months ago

lock14 commented 5 months ago

After some investigation, it was determined the reviewDecision field is unreliable as it can be set to null after a PR is merged. For example, if a user un-resolves a conversation on PR post-merge, then the reviewDecision will go from APPROVED to null.

This change removes the reviewDecision field and instead uses the underlying review data of a PR to determine the approval status of a commit.