abcxyz / github-metrics-aggregator

Apache License 2.0
11 stars 3 forks source link

fix: grant the automation service accounts developer permissions #236

Closed gjonathanhong closed 5 months ago

gjonathanhong commented 5 months ago

This change grants the automation service account permissions to make revisions to the cloud run services and also toset's on each of the service IAM configurations to avoid duplicate assignments.

I considered granting the developer role on the service account when rendering the template (see commit 042503b), because this would make it more explicit which IAM roles are assigned. But I decided against that idea, because the terraform module should provide everything that is required to run the service, even if that means the role assignment is hidden in the module itself.