abcxyz / github-metrics-aggregator

Apache License 2.0
11 stars 3 forks source link

Problems with README example config #254

Closed faximan closed 2 months ago

faximan commented 2 months ago

TL;DR

The provided variables do not match what Terraform is expecting.

Expected behavior

No response

Observed behavior

No response

Environment Details

I was running with terraform 1.5.4 on commit f1a8e93d6582be95bba447d00ef25babbabfd563 but I believe this is the same at head.

Additional information

Directly copying the config at https://github.com/abcxyz/github-metrics-aggregator?tab=readme-ov-file#deploy-the-service I get the following errors:

Additionally, I'd love for automation_service_account_member and webhook_domains to be explained what they should be set to, currently it is unclear what sort of pre-configuring I need to do for these two. At first, I left webhook_domains empty, but this caused a hard to decipher error at apply time:

  │ Error: Error creating ManagedSslCertificate: googleapi: Error 400: Invalid value for field 'resource.managed': ''. Managed certificate details must be specified if type = MANAGED., invalid
  │ 
  │   with module.github_metrics_aggregator.module.gclb[0].google_compute_managed_ssl_certificate.default,
  │   on .terraform/modules/github_metrics_aggregator.gclb/modules/gclb_cloud_run_backend/main.tf line 72, in resource "google_compute_managed_ssl_certificate" "default":
  │   72: resource "google_compute_managed_ssl_certificate" "default" {
  │ 
  ╵
faximan commented 2 months ago

Thank you!!