abcxyz / github-metrics-aggregator

Apache License 2.0
12 stars 3 forks source link

Add logging metric for event count #82

Closed shankiyani closed 1 year ago

sethvargo commented 1 year ago

@shan4993 we should talk about this a bit more. The code is fine, but there's a chicken-and-egg problem with having the IaC tooling register metrics (vs the app). For example, you may notice that EN has a dedicated service for registering metrics which is tightly coupled to the code. This was because otherwise you can accidentally create a circular dependency between the IaC and the app.

shankiyani commented 1 year ago

@shan4993 we should talk about this a bit more. The code is fine, but there's a chicken-and-egg problem with having the IaC tooling register metrics (vs the app). For example, you may notice that EN has a dedicated service for registering metrics which is tightly coupled to the code. This was because otherwise you can accidentally create a circular dependency between the IaC and the app.

This is fair, i wasnt sure what would happen if the metric is created but the logs don't exist yet. I assumed it would just be an empty graph but maybe that assumption is incorrect.